Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add patch, list, update verbs to the configmap role #1180

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur [email protected]

What does this PR do?

Add patch, list, update verbs to the configmap role. From the discussion here it was decided to use a configmap to store theia preferences. We need to have these verbs so that che-server can create the workspace-preferences-configamap on namespace creation.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20622

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha
Copy link
Contributor

tolusha commented Nov 18, 2021

Pls ,rebase on main branch

@vinokurig
Copy link
Contributor Author

@tolusha

Pls ,rebase on main branch

done

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2021

@vinokurig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-devworkspace-happy-path d06ef9e link true /test v7-devworkspace-happy-path
ci/prow/v7-stable-to-nightly d06ef9e link true /test v7-stable-to-nightly
ci/prow/v7-multi-host-next-deployment d06ef9e link true /test v7-multi-host-next-deployment
ci/prow/v8-multi-host-next-deployment d06ef9e link true /test v8-multi-host-next-deployment
ci/prow/v8-single-host-next-deployment d06ef9e link true /test v8-single-host-next-deployment
ci/prow/v8-e2e-all-namespaces-deployment d06ef9e link true /test v8-e2e-all-namespaces-deployment
ci/prow/v7-single-host-nightly-deployment d06ef9e link true /test v7-single-host-nightly-deployment
ci/prow/v8-che-behind-proxy d06ef9e link true /test v8-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit a434cc5 into main Nov 18, 2021
@tolusha tolusha deleted the che-20622 branch November 18, 2021 13:49
@che-bot che-bot added this to the 7.40 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants