Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding 'try-in-web-ide.yaml' yaml to github flow #1177

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Nov 15, 2021

What does this PR do?

eclipse-che/che#20664

Screenshot/screencast of this PR

Currently, the workspace startup is failing with

Failed to run the workspace: "Unrecoverable event occurred: 'Failed', 'Failed to pull image "quay.io/eclipse/che-golang-1.12:nightly": rpc error: code = Unknown desc = reading manifest nightly in quay.io/eclipse/che-golang-1.12: unknown: Tag nightly was deleted or has expired. To pull, revive via time machine', 'workspaceah3emmrb1cr6s0ti.dev-565dfd8cd7-c4sc9'"

@tolusha looks like the devfile need to be updated

What issues does this PR fix or reference?

eclipse-che/che#20664

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor

tolusha commented Nov 17, 2021

@ibuziuk
I've added add_comment: false. Is it ok for you?

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, ibuziuk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2021

@ibuziuk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-devworkspace-happy-path 6e0ad1b link true /test v7-devworkspace-happy-path
ci/prow/v7-stable-to-nightly 6e0ad1b link true /test v7-stable-to-nightly
ci/prow/v8-single-host-next-deployment 6e0ad1b link true /test v8-single-host-next-deployment
ci/prow/v8-e2e-all-namespaces-deployment 6e0ad1b link true /test v8-e2e-all-namespaces-deployment
ci/prow/v8-multi-host-next-deployment 6e0ad1b link true /test v8-multi-host-next-deployment
ci/prow/v7-multi-host-next-deployment 6e0ad1b link true /test v7-multi-host-next-deployment
ci/prow/v7-single-host-nightly-deployment 6e0ad1b link true /test v7-single-host-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 18, 2021

I've added add_comment: false. Is it ok for you?

yeah, sure thing

@tolusha tolusha merged commit 13ced1f into main Nov 18, 2021
@tolusha tolusha deleted the ibuziuk-patch-1 branch November 18, 2021 08:44
@che-bot che-bot added this to the 7.40 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants