chore: Refactoring build/test catalog scripts #1172
Conversation
tolusha
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun and
nickboldt
as code owners
|
Tested on both Minikube and OpenShift |
|
/retest |
.github/bin/minikube/test-olm.sh
Outdated
| @@ -25,12 +25,14 @@ trap "catchFinish" EXIT SIGINT | |||
|
|
|||
| runTest() { | |||
| local channel=next | |||
| local catalogImage=quay.io/eclipse/eclipse-che-kubernetes-opm-catalog:next | |||
There was a problem hiding this comment.
I think for ci we have to use ${IMAGE_REGISTRY_HOST} instead of quay.io to build and push catalog images to the private docker registry enabled on the minikube and use them in the test... That's a how tests are working currently.
| @@ -25,7 +25,7 @@ overrideDefaults() { | |||
| } | |||
|
|
|||
| runTests() { | |||
| "${OPERATOR_REPO}"/olm/testUpdate.sh "openshift" "stable" ${NAMESPACE} | |||
| "${OPERATOR_REPO}"/olm/testUpdate.sh -p openshift -c stable -i quay.io/eclipse/eclipse-che-openshift-opm-catalog:test -n ${NAMESPACE} | |||
There was a problem hiding this comment.
quay.io/eclipse/eclipse-che-openshift-opm-catalog:test - I think we have to use catalog image which was build on the Openshift ci. I don't think it starts from quay.io.
There was a problem hiding this comment.
OpenShift CI doesn't build any catalog sources in case of testing updates.
We use the existed one that is built during release.
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
|
@tolusha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
olm/buildCatalog.sholm/testCatalog.sholm/testUpdate.shquay.io/eclipse/eclipse-che-(kubernetes|openshift)-opm-catalog:nextcatalog image for next channelsquay.io/eclipse/eclipse-che-(kubernetes|openshift)-opm-catalog:testcatalog image for stable channels for testing purposeScreenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20602
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.