Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing exec connections on che task SIGINT termination. #51

Closed
wants to merge 4 commits into from
Closed

Fix closing exec connections on che task SIGINT termination. #51

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
939dbf9
Fix closing exec connections on task SIGINT termination.
AndrienkoAleksandr Nov 1, 2019
613e5ba
Revert update golang version. It is not mandatory.
AndrienkoAleksandr Nov 4, 2019
4cc2e36
Revert bad changes.
AndrienkoAleksandr Nov 4, 2019
3db2969
Use ubi9-minimal image for CRW che-machine-exec
AndrienkoAleksandr Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dockerfiles/ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,16 @@
# Dockerfile defines che-machine-exec production image eclipse/che-machine-exec-dev
#

FROM golang:1.10.3-alpine as builder
FROM golang:1.10.7-alpine as builder
WORKDIR /go/src/github.com/eclipse/che-machine-exec/
COPY . .
RUN CGO_ENABLED=0 GOOS=linux go build -a -ldflags '-w -s' -a -installsuffix cgo -o che-machine-exec .
RUN apk add --no-cache ca-certificates

RUN adduser -D -g '' unprivilegeduser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the meaning of this instruction as we're in another image/container at runtime ?


FROM scratch
FROM busybox
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
COPY --from=builder /etc/passwd /etc/passwd
COPY --from=builder /go/src/github.com/eclipse/che-machine-exec/che-machine-exec /go/bin/che-machine-exec

USER unprivilegeduser
Expand Down