This repository has been archived by the owner on Mar 23, 2022. It is now read-only.
Add attributes to tunnel to store meta information. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <[email protected]>
tolusha
approved these changes
Mar 16, 2020
|
45 tasks
We need to have ability store meta-data information in the tunnel. For issue how it is related to eclipse-che/che#16250 we need to store token. |
|
|
|
@skabashnyuk I'm not sure about token's lifetime, but che-machine-exec uses it only during terminal initializing...
Che-machine-exec loses all websocket connections and users have to provide new token once CloudShell UI is refreshed. |
sleshchenko
approved these changes
Mar 17, 2020
skabashnyuk
approved these changes
Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
eclipse-che/che#16250
What issues does this PR fix or reference?
Add attributes to tunnel to store meta information.
Signed-off-by: Oleksandr Andriienko [email protected]