Add recreate update instructions #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Apr 26, 2018
ghost
approved these changes
May 2, 2018
gazarenkov
reviewed
May 3, 2018
| full workspaces stopping will be performed. | ||
| Therefore, `/api/system/stop` API contract changed slightly - now it tries to do the second behavior by default. Full shutdown with workspaces stop | ||
| can be requested with `shutdown=true` parameter. | ||
|
|
There was a problem hiding this comment.
What is READY_TO_SHUTDOWN and how differs from PREPARING_TO_SHUTDOWN state?
As I understand it when you perform "stop" the system:
- tries to stop workspaces gracefully (if infra supports recovery)
- otherwise it just stopping workspaces
that's PREPARING_TO_SHUTDOWN state?
when all stopped it becomes READY_TO_SHUTDOWN which allows master to stop the process?
There was a problem hiding this comment.
Yes, that's correct.
There was a problem hiding this comment.
Added sentence when PREPARING_TO_SHUTDOWN becomes READY_TO_SHUTDOWN
gazarenkov
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recreate update instructions into openshift admin guide.