Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Adding a step to verify Authorized Applications #2624

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

satyamburhade
Copy link

@satyamburhade satyamburhade commented Jul 12, 2023

What does this pull request change?

Docs: Adding a step to verify Authorized Applications

Verify that the Application is Authorized, Click your avatar and go to Edit Profile → Applications → Authorized Applications

What issues does this pull request fix or reference?

It has been observed that users skip checking whether the Application is authorized or not, Which causes OAuth failure

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Verify that the Application is Authorized, Click your avatar and go to Edit Profile → Applications → Authorized Applications
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

⚡️ Deploying pull request preview...

@ibuziuk ibuziuk requested a review from vinokurig July 13, 2023 07:53
Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not relevant for the Admin which setups the application. The Authorized applications list shows applications authorised for the specific user, but not for the Admin.

…ab-authorized-application.adoc

Co-authored-by: Ilya Buziuk <[email protected]>
@satyamburhade
Copy link
Author

Hello @vinokurig,
Yes, I agree but even when a person who is configuring and testing an OAuth connection will have an idea to check and verify the step.

@vinokurig
Copy link
Contributor

but even when a person who is configuring and testing an OAuth connection will have an idea to check and verify the step.

This should be taken out of the scope. May be add verification steps like here https://www.eclipse.org/che/docs/stable/administration-guide/importing-untrusted-tls-certificates/

@satyamburhade
Copy link
Author

@vinokurig I think it's more of a config step because if it's not done then the user will not be able to use OAuth. So if I change it like below will it be okay? WDYT?

Make sure that the Application is Authorized, Click your avatar and go to Edit Profile → Applications → Authorized Applications

@vinokurig
Copy link
Contributor

@satyamburhade

I think it's more of a config step because if it's not done then the user will not be able to use OAuth.

Why the user will not be able to use the OAuth? What configuration step are we missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants