Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Configure disable subdomain isolation #2548

Merged
merged 5 commits into from
Feb 9, 2023
Merged

feat: Configure disable subdomain isolation #2548

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0d23e3
feat: Configure disalbe subdomain isolation
tolusha Feb 8, 2023
cb288e0
Update modules/administration-guide/partials/proc_applying-the-github…
tolusha Feb 9, 2023
8d91cec
Update modules/administration-guide/partials/proc_applying-the-github…
tolusha Feb 9, 2023
c20fd77
Update modules/administration-guide/partials/proc_applying-the-github…
tolusha Feb 9, 2023
2934e3e
Update modules/administration-guide/partials/proc_applying-the-github…
max-cx Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...es/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,18 @@ metadata:
app.kubernetes.io/component: oauth-scm-configuration
annotations:
che.eclipse.org/oauth-scm-server: github
che.eclipse.org/scm-server-endpoint: <github_server_url> <2>
che.eclipse.org/scm-server-endpoint: __<github_server_url>__ <2>
che.eclipse.org/scm-github-disable-subdomain-isolation: "__<true_or_false>__" <3>
type: Opaque
data:
id: __<Base64_GitHub_OAuth_Client_ID>__ <3>
secret: __<Base64_GitHub_OAuth_Client_Secret>__ <4>
id: __<Base64_GitHub_OAuth_Client_ID>__ <4>
secret: __<Base64_GitHub_OAuth_Client_Secret>__ <5>
----
<1> The {prod-short} namespace. The default is `{prod-namespace}`.
<2> A *GitHub Enterprise Server URL*. By default `https://github.com` is used for the `SAAS` version.
<3> The Base64-encoded *GitHub OAuth Client ID*.
<4> The Base64-encoded *GitHub OAuth Client Secret*.
<2> A *GitHub Enterprise Server URL*. By default, `https://github.com` is used for the `SAAS` version.
<3> Subdomain isolation for GitHub Enterprise Server. To disable subdomain isolation, set this to `"true"`. To enable subdomain isolation, set this to `"false"`.
<4> The Base64-encoded *GitHub OAuth Client ID*.
<5> The Base64-encoded *GitHub OAuth Client Secret*.

. Apply the Secret:
+
Expand Down