Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
procedures: Migration to devworkspace engine #2159
procedures: Migration to devworkspace engine #2159
Changes from 16 commits
f7fd96b
2f8e763
b252cd8
79f3fe8
e0402d2
4739686
4848a2e
1675388
c75d2a5
13fdc85
99f6d2b
f95698e
a4a823a
5fabedf
23f538d
70a240a
60faaae
816781b
07ad4f9
9dea068
34d60bd
6221b9b
c030d4f
448a42f
83cda22
82eb83e
84a5b1d
c4f58f1
10e8655
bd3c49a
1082018
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is admin of Eclipse Che obligated to push back to Git repositories and then all stop workspaces?
Shouldn't workspace be stopped automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of such possibility. This is a general recommendation about working workspaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tolusha @skabashnyuk folks, what is the SOP for stopping all running che-server workspaces? atm the implementation for automatic stopping works only after the engine switch from che-server to devWorkpace - eclipse-che/che#20631
According to the procedure from this PR, the workspaces are expected to be stopped before the engine switch, so wondering how admin is expected to proceed in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than displaying a script that the user should edit, could we have a script that can receive parameters and that the user can download without modifications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User should not edit any scrits but copy/paster into console to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the step should be "Download the script from following URL" (URL preferably including the release version) rather than "Select, copy and paste a script we display in the content of the script in the docs".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script depends on doc templates like {prod-namespace} and {prod-checluster}.
I can't put this script anywhere but doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have a script where {orch-cli}, {prod-namespace} and {prod-checluster} are arguments? Now we would be embedding untestable code inside the docs, it feels weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parameters are something that users should not care about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An observation is that the scripts would work only if Eclipse Che / CRW is installed in the recomended namespace e.g.
eclipse-che
for upstream. However, there is possibility for installing operator in different namespaces e.g. dogfooding on che-dev clusterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrienkoAleksandr I tried to verify the procedure, but there are no instructions for generating
eclipse-che-users.txt
Running the script from step 4 just prints smth.like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, my bad the file is generated on step 4 - https://github.com/eclipse/che-docs/pull/2159/files#diff-77c9e22f032894ec21ce593ccfa6ec9c032e1847c7da18431442f931b803b026R30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it would be great to use some env var for namespace. Otherwise, it will work only for defaults installations, and will not work for specific setups like dogfooding / Developer Sandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It make perfect sense but all documentation is based on the fact that Eclipse Che is deployed in {prod-namespace}
which is
eclipse-che
(openshift-workspaces
)So, to be honest I don't know how to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume if namespace is different, then user must change it in the scrips manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably introduce NAMESPACE env var, it is really error-prone to expect from an admin to patch the scripts manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully agree with @ibuziuk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so into which repo will we move the script(s) so that they can evolve outside the docs, and not be beholden to doc-related validation rules? Also then we can tell a user "set your namespace variable, curl this URL, run this script, and you're done!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use https://github.com/devfile/devworkspace-operator-docs - maybe a subfolder like https://github.com/devfile/devworkspace-operator-docs/tree/main/migration/ -- or do we need a new repo?