Make note of assumptions on the secure endpoints #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and devfile about the assumptions made to make it really secure.
metlos
requested review from
yhontyk,
rkratky,
slemeur and
themr0c
as code owners
themr0c
approved these changes
Feb 17, 2020
MichalMaler
pushed a commit
to MichalMaler/che-docs
that referenced
this pull request
Feb 20, 2020
…yml (eclipse-che#1075) and devfile about the assumptions made to make it really secure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a note on the secure attribute of the endpoints in both the meta.yml and devfile about the assumptions made to make it really secure.
What issues does this PR fix or reference?
eclipse-che/che#15651, eclipse-che/che#15890
Please do not merge until the above issue/PR are closed/merged.