Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Add workflow for checking sidecar digests #380

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Add workflow for checking sidecar digests #380

merged 3 commits into from
Apr 29, 2021

Conversation

mkuznyetsov
Copy link
Contributor

Signed-off-by: Mykhailo Kuznietsov [email protected]

What does this PR do?

Add regularly scheduled workflow for checking sidecar image digests in base_images file. If new digest is detected, a pull request with it's update will be generated

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge it and see what happens.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a description/purpose for this script so future maintainers will know why we're doing this (around line 9)

@nickboldt
Copy link
Contributor

Follow up work in eclipse-che/che#19695

If you add a comment to the top of the file explaining the purpose here, then we should be good to merge this as is.

@benoitf @ericwill do you agree?

@ericwill
Copy link
Contributor

Follow up work in eclipse/che#19695

If you add a comment to the top of the file explaining the purpose here, then we should be good to merge this as is.

@benoitf @ericwill do you agree?

Agreed

@nickboldt nickboldt merged commit 7017a2a into master Apr 29, 2021
@nickboldt nickboldt deleted the digest-check branch April 29, 2021 16:50
@che-bot che-bot added this to the 7.30 milestone Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants