This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Add workflow for checking sidecar digests #380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykhailo Kuznietsov <[email protected]>
mkuznyetsov
requested review from
benoitf,
ericwill,
JPinkney,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
April 27, 2021 14:40
nickboldt
reviewed
Apr 27, 2021
nickboldt
reviewed
Apr 27, 2021
nickboldt
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's merge it and see what happens.
benoitf
reviewed
Apr 27, 2021
nickboldt
approved these changes
Apr 27, 2021
nickboldt
suggested changes
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a description/purpose for this script so future maintainers will know why we're doing this (around line 9)
Follow up work in eclipse-che/che#19695 If you add a comment to the top of the file explaining the purpose here, then we should be good to merge this as is. |
Agreed |
nickboldt
approved these changes
Apr 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykhailo Kuznietsov [email protected]
What does this PR do?
Add regularly scheduled workflow for checking sidecar image digests in base_images file. If new digest is detected, a pull request with it's update will be generated
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.