feat: remove dependency on Workspace API #695
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
packages/dashboard-frontend/src/Layout/Navigation/index.module.css
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/components/EditorTools/index.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/components/EditorTools/index.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/components/EditorTools/index.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/store/Workspaces/Settings/selectors.ts
Outdated
Show resolved
Hide resolved
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
packages/dashboard-frontend/src/pages/GetStarted/GetStartedTab/ImportFromGit/index.tsx
Show resolved
Hide resolved
packages/dashboard-frontend/src/pages/GetStarted/__tests__/GetStarted.spec.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/pages/WorkspaceDetails/index.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/store/DockerConfig/selectors.ts
Outdated
Show resolved
Hide resolved
| timeouts: { | ||
| inactivityTimeout: -1, | ||
| runTimeout: -1, | ||
| startTimeout: 300, | ||
| }, | ||
| } as any, |
There was a problem hiding this comment.
Can you elaborate on why you need to remove the runTimeout field?
|
Click here to review and test in web IDE: |
…ncy on Workspace API
Codecov Report
@@ Coverage Diff @@
## main #695 +/- ##
==========================================
+ Coverage 62.42% 63.46% +1.04%
==========================================
Files 289 283 -6
Lines 8941 8413 -528
Branches 1435 1325 -110
==========================================
- Hits 5581 5339 -242
+ Misses 3120 2855 -265
+ Partials 240 219 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
packages/dashboard-frontend/src/pages/GetStarted/GetStartedTab/SamplesListGallery.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/services/helpers/devworkspace.ts
Outdated
Show resolved
Hide resolved
… feat: remove dependency on Workspace API
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-695 |
… fixup! feat: remove dependency on Workspace API
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-695 |
| @@ -15,7 +15,6 @@ import { baseApiPath } from '../../constants/config'; | |||
| import { getSchema } from '../../services/helpers'; | |||
| import { devfileVersionSchema } from '../../constants/schemas'; | |||
| import { restParams } from '../../typings/models'; | |||
| import * as devfileSchemaV100 from '../../devfileSchemas/1.0.0/devfile.json'; | |||
There was a problem hiding this comment.
@olexii4 since we are not doing the validation of v1 I'm wondering if the factory automatic conversion from v1 to v2 is going to still work?
There was a problem hiding this comment.
All validation for the Devfile v1 during factory flow on the che-server side.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.5 :: dashboard_3.x/169: Console, Changes, Git Data |
|
Build 3.5 :: sync-to-downstream_3.x/1961: Console, Changes, Git Data |
|
Build 3.5 :: push-latest-container-to-quay_3.x/1510: Console, Changes, Git Data |
|
Build 3.5 :: copyIIBsToQuay/650: Console, Changes, Git Data |
|
Build 3.5 :: push-latest-container-to-quay_3.x/1510: Copied: dashboard-rhel8; /job/DS_CI/job/update-digests_3.x triggered; |
|
Build 3.5 :: get-sources-rhpkg-container-build_3.x/1892: dashboard : 3.x :: Build 49994177 : quay.io/devspaces/dashboard-rhel8:3.5-8 |
|
Build 3.5 :: sync-to-downstream_3.x/1961: Build container: devspaces-dashboard synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1892 triggered; |
|
Build 3.5 :: dashboard_3.x/169: Upstream sync done; /DS_CI/sync-to-downstream_3.x/1961 triggered |
|
Build 3.5 :: update-digests_3.x/1839: Console, Changes, Git Data |
|
Build 3.5 :: update-digests_3.x/1839: No new images detected: nothing to do! |
Signed-off-by: Oleksii Orel [email protected]
What does this PR do?
Remove dependency on Workspace API.
What issues does this PR fix or reference?
fixes eclipse-che/che#21846
You can test this PR at https://eclipse-che.apps.cluster-pd8pf.pd8pf.sandbox1822.opentlc.com/dashboard/