-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard frontend sanity check #682
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-682 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-682 |
I think it is not very clear to have only one temporary error message, which will be hidden after 10 seconds in the case when the session expired: It is much better to have the message with the refreshing timer which we have when opening the 'User Preferences' page: @ibuziuk WDYT? |
@olexii4 @akurinnoy I actually like the current UX with |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-682 |
@akurinnoy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.4 :: dashboard_3.x/153: Console, Changes, Git Data |
Build 3.4 :: sync-to-downstream_3.x/1550: Console, Changes, Git Data |
What does this PR do?
This PR adds the custom redux middleware to the dashboard. The middleware triggers the sanity check each time before requesting either the che-server API or the dashboard backend. The sanity check results get cached, so no unnecessary extra requests will be done.
If the sanity check fails, only one error alert will be shown. All other error alerts will be suppressed.
Screenshots
In preload phase
When the dashboard loaded
What issues does this PR fix or reference?
eclipse-che/che#21799
- add API sanity check with a single request to prevent showing multiple error messages
- if after all checks above and re-tries API is still failing we show a single error with the session expired message and redirect to the login page
Is it tested? How?