Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bootstrap queue #679

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Fix the bootstrap queue #679

merged 3 commits into from
Nov 23, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 22, 2022

Signed-off-by: Oleksii Orel [email protected]

What does this PR do?

Fix the bootstrap queue to guarantee to have resourceVersion before subscribing to the onChange event.

What issues does this PR fix or reference?

fixes eclipse-che/che#21809

Знімок екрана 2022-11-22 о 18 42 33

Signed-off-by: Oleksii Orel <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Nov 22, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-679

@che-bot
Copy link
Contributor

che-bot commented Nov 23, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-679

@openshift-ci openshift-ci bot removed the lgtm label Nov 23, 2022
@che-bot
Copy link
Contributor

che-bot commented Nov 23, 2022

Click here to review and test in web IDE: Contribute

@openshift-ci openshift-ci bot added the lgtm label Nov 23, 2022
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olexii4 should we also backport to 7.56.x ?

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-679

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v10-dashboard-happy-path 882d60c link true /test v10-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olexii4
Copy link
Contributor Author

olexii4 commented Nov 23, 2022

@olexii4 should we also backport to 7.56.x ?

Yes, we should. I have created a PR.

@olexii4 olexii4 merged commit 07a6e5a into main Nov 23, 2022
@olexii4 olexii4 deleted the CHE-21809 branch November 23, 2022 10:26
olexii4 added a commit that referenced this pull request Nov 23, 2022
* fix the bootstrap queue

Signed-off-by: Oleksii Orel <[email protected]>
@che-bot che-bot added this to the 7.57 milestone Nov 23, 2022
olexii4 added a commit that referenced this pull request Nov 23, 2022
* fix the bootstrap queue

Signed-off-by: Oleksii Orel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspaces are stopped unexpectedly during startup
4 participants