Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't request workspace if user namespace is not created #619

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 2, 2022

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

  • Don't request workspace if user namespace is not created
  • Update error message if user tries to start a workspace when namespace is not created

What issues does this PR fix or reference?

eclipse-che/che#21582

Is it tested? How?

N/A

Release Notes

N/A

Docs PR

N/A

screenshot-192 168 39 83 nip io-2022 09 02-17_18_31

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2022

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-619

@tolusha tolusha requested a review from benoitf September 2, 2022 16:04
@tolusha
Copy link
Contributor Author

tolusha commented Sep 4, 2022

/test v8-dashboard-happy-path

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Sep 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2022

New changes are detected. LGTM label has been removed.

@che-bot
Copy link
Contributor

che-bot commented Sep 5, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-619

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2022

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path 727cee0 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 8e2a95e into main Sep 5, 2022
@tolusha tolusha deleted the 21582 branch September 5, 2022 11:57
@che-bot che-bot added this to the 7.54 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants