Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: factory parameters #588

Merged
merged 2 commits into from
Jul 23, 2022
Merged

fix: factory parameters #588

merged 2 commits into from
Jul 23, 2022

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes the ability to provide storageType for a new workspace via query param in the factory URL.

What issues does this PR fix or reference?

fixes eclipse-che/che#21569

@akurinnoy akurinnoy self-assigned this Jul 22, 2022
@che-bot
Copy link
Contributor

che-bot commented Jul 22, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-588

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just postpone merging till next week

@openshift-ci openshift-ci bot removed the lgtm label Jul 22, 2022
@che-bot
Copy link
Contributor

che-bot commented Jul 22, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-588

@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2022

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path f97a0ef link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibuziuk ibuziuk merged commit 9713557 into main Jul 23, 2022
@ibuziuk ibuziuk deleted the fix-factory-params branch July 23, 2022 17:19
@che-bot che-bot added this to the 7.51 milestone Jul 23, 2022
@akurinnoy akurinnoy restored the fix-factory-params branch July 26, 2022 12:58
@akurinnoy akurinnoy deleted the fix-factory-params branch July 26, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not start a workspace with &storageType=ephemeral attribute
4 participants