feat: manage default uri plugins for DevWorkspaces #426

dkwon17 · 2021-12-15T16:33:37Z

Signed-off-by: David Kwon [email protected]

What does this PR do?

This PR is the same PR as #425, except, its source branch is in the eclipse-che/che-dashboard repository rather than dkwon17/che-dashboard.

What issues does this PR fix or reference?

eclipse-che/che#20090

che-bot · 2021-12-15T16:33:39Z

Can one of the admins verify this patch?

codecov · 2021-12-15T16:41:01Z

Codecov Report

Merging #426 (ebf10c8) into main (731080d) will increase coverage by 0.12%.
The diff coverage is 64.61%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   49.66%   49.78%   +0.12%     
==========================================
  Files         211      213       +2     
  Lines        7211     7273      +62     
  Branches     1194     1204      +10     
==========================================
+ Hits         3581     3621      +40     
- Misses       3288     3305      +17     
- Partials      342      347       +5

Impacted Files	Coverage Δ
...ontend/src/store/Workspaces/devWorkspaces/index.ts	`9.95% <0.00%> (-0.35%)`	⬇️
...rvices/dashboard-backend-client/serverConfigApi.ts	`36.36% <36.36%> (ø)`
.../devworkspace/DevWorkspaceDefaultPluginsHandler.ts	`78.94% <78.94%> (ø)`
...orkspace-client/devworkspace/devWorkspaceClient.ts	`45.91% <80.00%> (+0.54%)`	⬆️
...evworkspace-client/services/api/serverConfigApi.ts	`45.00% <100.00%> (ø)`
.../workspace-client/devworkspace/converters/index.ts	`82.75% <100.00%> (+0.61%)`	⬆️
...rvices/dashboard-backend-client/devWorkspaceApi.ts	`70.27% <0.00%> (+2.70%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731080d...ebf10c8. Read the comment docs.

github-actions · 2021-12-16T17:27:25Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

dmytro-ndp · 2021-12-16T17:41:56Z

[dashboard-ci-test]

che-bot · 2021-12-16T18:00:15Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:426
Che server image: quay.io/crw_pr/che-server:426

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts

dkwon17 · 2021-12-18T22:41:21Z

packages/dashboard-backend/src/devworkspace-client/services/api/serverConfigApi.ts

-const NAME = process.env.CHE_CRD_OBJECT_NAME;
-const NAMESPACE = process.env.CHE_NAMESPACE;
+const NAME = process.env.CHECLUSTER_CR_NAME;
+const NAMESPACE = process.env.CHECLUSTER_CR_NAMESPACE;


Renamed to match env variable names from the che-operator: https://github.com/dkwon17/che-operator/blob/051d7bd9d30d1b48a9752b095426c39f2b19aee1/pkg/deploy/dashboard/deployment_dashboard.go#L59-L64

github-actions · 2021-12-18T22:49:12Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

github-actions · 2021-12-18T22:52:43Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

github-actions · 2021-12-18T23:18:13Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

...tend/src/services/workspace-client/devworkspace/__tests__/devWorkspaceClient.onStart.spec.ts

packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts

ibuziuk · 2021-12-22T16:48:27Z

/retest

dkwon17 · 2021-12-22T16:56:03Z

Thank you for the reviews everyone, I made a new commit that sets the default plugins in the redux store, and adds tests

github-actions · 2021-12-22T17:06:04Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

github-actions · 2021-12-22T17:25:13Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

ibuziuk · 2021-12-23T15:08:45Z

/retest

olexii4

LGTM

openshift-ci · 2021-12-23T15:10:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, amisevsk, dkwon17, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dmytro-ndp · 2021-12-23T15:51:21Z

[dashboard-ci-test]

che-bot · 2021-12-23T16:20:33Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:426
Che server image: quay.io/crw_pr/che-server:426

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

musienko-maxim · 2021-12-23T21:49:03Z

/test v8-dashboard-happy-path

openshift-ci · 2021-12-23T21:54:29Z

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v8-dashboard-happy-path	`8457001`	link	true	`/test v8-dashboard-happy-path`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

musienko-maxim · 2021-12-23T23:26:05Z

I rechecked the image from this PR locally the problem with the Happy Path test did not reproduce. We can merge this PR

openshift-ci · 2021-12-24T14:25:53Z

New changes are detected. LGTM label has been removed.

Signed-off-by: David Kwon <[email protected]>

github-actions · 2021-12-24T14:42:28Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

github-actions · 2021-12-24T14:47:11Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-426

dkwon17 requested review from akurinnoy and olexii4 as code owners December 15, 2021 16:33

dkwon17 mentioned this pull request Dec 15, 2021

feat: manage default uri plugins for DevWorkspaces #425

Closed

ibuziuk approved these changes Dec 15, 2021

View reviewed changes

openshift-ci bot assigned ibuziuk Dec 15, 2021

openshift-ci bot added the lgtm label Dec 15, 2021

amisevsk approved these changes Dec 16, 2021

View reviewed changes

openshift-ci bot assigned amisevsk Dec 16, 2021

dkwon17 force-pushed the che-20090 branch from 87493bc to a313f38 Compare December 16, 2021 16:57

openshift-ci bot removed the lgtm label Dec 16, 2021

dkwon17 force-pushed the che-20090 branch 2 times, most recently from cd82a31 to 6283699 Compare December 16, 2021 17:11

akurinnoy reviewed Dec 17, 2021

View reviewed changes

packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts Outdated Show resolved Hide resolved

dkwon17 force-pushed the che-20090 branch 3 times, most recently from 3a37017 to 0ffc7d1 Compare December 18, 2021 22:36

dkwon17 commented Dec 18, 2021

View reviewed changes

dkwon17 force-pushed the che-20090 branch from 0ffc7d1 to ebf10c8 Compare December 18, 2021 23:06

akurinnoy reviewed Dec 20, 2021

View reviewed changes

...tend/src/services/workspace-client/devworkspace/__tests__/devWorkspaceClient.onStart.spec.ts Show resolved Hide resolved

akurinnoy approved these changes Dec 20, 2021

View reviewed changes

openshift-ci bot assigned akurinnoy Dec 20, 2021

openshift-ci bot added the lgtm label Dec 20, 2021

olexii4 reviewed Dec 21, 2021

View reviewed changes

packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts Outdated Show resolved Hide resolved

dkwon17 force-pushed the che-20090 branch 2 times, most recently from e4c2c1a to 0d7688d Compare December 21, 2021 22:57

dkwon17 mentioned this pull request Dec 21, 2021

Update redux store with default plugins from CR without refreshing dashboard eclipse-che/che#20960

Closed

dkwon17 force-pushed the che-20090 branch from 0d7688d to df323c6 Compare December 22, 2021 16:51

dkwon17 force-pushed the che-20090 branch from df323c6 to 8457001 Compare December 22, 2021 17:12

olexii4 approved these changes Dec 23, 2021

View reviewed changes

openshift-ci bot assigned olexii4 Dec 23, 2021

openshift-ci bot added the lgtm label Dec 23, 2021

dkwon17 force-pushed the che-20090 branch from 8457001 to 791474b Compare December 24, 2021 14:25

openshift-ci bot removed the lgtm label Dec 24, 2021

feat: manage default plugin uris for DevWorkspaces

91313dc

Signed-off-by: David Kwon <[email protected]>

dkwon17 force-pushed the che-20090 branch from 791474b to 91313dc Compare December 24, 2021 14:29

dkwon17 merged commit dc2d20c into main Dec 24, 2021

dkwon17 deleted the che-20090 branch December 24, 2021 15:26

che-bot added this to the 7.42 milestone Dec 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: manage default uri plugins for DevWorkspaces #426

feat: manage default uri plugins for DevWorkspaces #426

dkwon17 commented Dec 15, 2021 •

edited

Loading

che-bot commented Dec 15, 2021

codecov bot commented Dec 15, 2021 •

edited

Loading

github-actions bot commented Dec 16, 2021

dmytro-ndp commented Dec 16, 2021

che-bot commented Dec 16, 2021

dkwon17 Dec 18, 2021

github-actions bot commented Dec 18, 2021

github-actions bot commented Dec 18, 2021

github-actions bot commented Dec 18, 2021

ibuziuk commented Dec 22, 2021

dkwon17 commented Dec 22, 2021

github-actions bot commented Dec 22, 2021

github-actions bot commented Dec 22, 2021

ibuziuk commented Dec 23, 2021

olexii4 left a comment

openshift-ci bot commented Dec 23, 2021

dmytro-ndp commented Dec 23, 2021

che-bot commented Dec 23, 2021

musienko-maxim commented Dec 23, 2021

openshift-ci bot commented Dec 23, 2021

musienko-maxim commented Dec 23, 2021

openshift-ci bot commented Dec 24, 2021

github-actions bot commented Dec 24, 2021

github-actions bot commented Dec 24, 2021

feat: manage default uri plugins for DevWorkspaces #426

feat: manage default uri plugins for DevWorkspaces #426

Conversation

dkwon17 commented Dec 15, 2021 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

che-bot commented Dec 15, 2021

codecov bot commented Dec 15, 2021 • edited Loading

Codecov Report

github-actions bot commented Dec 16, 2021

dmytro-ndp commented Dec 16, 2021

che-bot commented Dec 16, 2021

dkwon17 Dec 18, 2021

Choose a reason for hiding this comment

github-actions bot commented Dec 18, 2021

github-actions bot commented Dec 18, 2021

github-actions bot commented Dec 18, 2021

ibuziuk commented Dec 22, 2021

dkwon17 commented Dec 22, 2021

github-actions bot commented Dec 22, 2021

github-actions bot commented Dec 22, 2021

ibuziuk commented Dec 23, 2021

olexii4 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 23, 2021

dmytro-ndp commented Dec 23, 2021

che-bot commented Dec 23, 2021

musienko-maxim commented Dec 23, 2021

openshift-ci bot commented Dec 23, 2021

musienko-maxim commented Dec 23, 2021

openshift-ci bot commented Dec 24, 2021

github-actions bot commented Dec 24, 2021

github-actions bot commented Dec 24, 2021

dkwon17 commented Dec 15, 2021 •

edited

Loading

codecov bot commented Dec 15, 2021 •

edited

Loading