Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Get rid of pluginRegistryURL #1158

Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore: Get rid of pluginRegistryURL #1158

merged 1 commit into from
Aug 7, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 6, 2024

What does this PR do?

Stop reading the list of devfiles from the internal devfile registry.

What issues does this PR fix or reference?

eclipse-che/che#23026

Is it tested? How?

N/A

Release Notes

Stop reading the list of devfiles from the internal devfile registry.

Docs PR

Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Aug 6, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Aug 6, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1158

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1158", name: che-dashboard}]}}]"

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (f3a22d3) to head (28966f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   89.47%   89.16%   -0.32%     
==========================================
  Files         417      417              
  Lines       42747    42711      -36     
  Branches     2878     2860      -18     
==========================================
- Hits        38250    38083     -167     
- Misses       4467     4596     +129     
- Partials       30       32       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tolusha tolusha merged commit 608f5d8 into main Aug 7, 2024
18 of 20 checks passed
@tolusha tolusha deleted the 23026_2 branch August 7, 2024 12:28
@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/519: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/519: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7369 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: update-digests_3.x/7251: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants