feat: serve airgap samples #1142
Conversation
|
Click here to review and test in web IDE: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
- Coverage 89.67% 89.36% -0.32%
==========================================
Files 415 417 +2
Lines 42461 42708 +247
Branches 2843 2872 +29
==========================================
+ Hits 38077 38165 +88
- Misses 4357 4515 +158
- Partials 27 28 +1 ☔ View full report in Codecov by Sentry. |
build/dockerfiles/airgap.sh
Outdated
| archiveFileName="$(echo "${repoURL#https://}" | cut -d '/' -f 2-3 | tr '/' '_').zip" | ||
| echo "[INFO] Downloading ${repoURL} into ${archiveFileName}" | ||
|
|
||
| # TODO Add token via GitHub Secret |
There was a problem hiding this comment.
do we need a token even if the repos are public?
|
TODO:
|
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1142 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1142", name: che-dashboard}]}}]" |
Signed-off-by: Anatolii Bazko <[email protected]>
| async () => { | ||
| const token = getServiceAccountToken(); | ||
| const { airGapSampleApi } = getDevWorkspaceClient(token); | ||
| return airGapSampleApi.list(); | ||
| }, |
Check failure
Code scanning / CodeQL
Missing rate limiting High
Signed-off-by: Anatolii Bazko <[email protected]>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1142 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1142", name: che-dashboard}]}}]" |
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1142 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1142", name: che-dashboard}]}}]" |
|
|
||
| private readAirGapIndex(): Array<api.IAirGapSample> { | ||
| const airGapIndexFilePath = this.getAirGapIndexFilePath(); | ||
| if (!fs.existsSync(airGapIndexFilePath)) { |
There was a problem hiding this comment.
I don't think it's necessary to do all these synchronous fs operations on every request, because the file path doesn't change from one request to another. I'd do it once at the class instantiation.
Signed-off-by: Anatolii Bazko <[email protected]>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1142 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1142", name: che-dashboard}]}}]" |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.16 :: dashboard_3.x/518: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7359: Console, Changes, Git Data |
|
Build 3.16 :: push-latest-container-to-quay_3.x/4836: Console, Changes, Git Data |
|
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7344: dashboard : 3.x :: Build 63119510 : quay.io/devspaces/dashboard-rhel8:3.16-15 |
|
Build 3.16 :: update-digests_3.x/7238: Console, Changes, Git Data |
|
Build 3.16 :: dashboard_3.x/518: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7359 triggered |
|
Build 3.16 :: operator-bundle_3.x/3379: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7360: Console, Changes, Git Data |
|
Build 3.16 :: push-latest-container-to-quay_3.x/4837: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7360: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7345 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.16 :: operator-bundle_3.x/3379: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7360 triggered |
|
Build 3.16 :: copyIIBsToQuay/2738: Console, Changes, Git Data |
|
Build 3.16 :: dsc_3.x/1977: Console, Changes, Git Data |
|
Build 3.16 :: update-digests_3.x/7238: Detected new images: rebuild operator-bundle |
|
Build 3.16 :: dsc_3.x/1977: 3.16.0-CI |
|
Build 3.16 :: copyIIBsToQuay/2738: 3.16 |
What does this PR do?
feat: serve airgap samples
What issues does this PR fix or reference?
eclipse-che/che#23026
Is it tested? How?
Manual testing
Release Notes
N/A
Docs PR
N/A