-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch delete token error if namespace is not provisioned #1046
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1046 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1046", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, take a look at the screencast since I'm not sure PR is addressing the issue I'm facing:
Screen.Recording.2024-01-19.at.13.45.50.mov
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1046 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1046", name: che-dashboard}]}}]" |
Signed-off-by: Oleksii Orel <[email protected]>
@ibuziuk Could you recheck these changes? I fixed a bug and added tests. 2024-01-24.04.00.07.mov |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1046 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1046", name: che-dashboard}]}}]" |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
+ Coverage 88.24% 88.28% +0.03%
==========================================
Files 389 390 +1
Lines 39845 39984 +139
Branches 2650 2666 +16
==========================================
+ Hits 35163 35299 +136
- Misses 4656 4659 +3
Partials 26 26 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Needs another approach. |
What does this PR do?
Do not throw an error on Git Service revoke if the related oauth access token is not deleted.
Currently dashboard has a timer that controls che-server's namespace provision API request: If the namespace provision is executed another provision request will be ignored for 15 seconds:
che-dashboard/packages/dashboard-frontend/src/store/SanityCheck/index.ts
Lines 83 to 88 in 4b58763
This timer causes a side effect that activates the revoke a Git service button after an actual revoke is performed. With this PR we intercept the delete token error on such case and deactivating the revoke button.
What issues does this PR fix or reference?
Is it tested? How?
Git Services
tab and revoke the GitHub authorisation.Personal Access Tokens
tab and then quickly switch back to theGit Services
tab.Release Notes
Docs PR