Fix getter for error messages (#338)

* fix: fix getter for error messages Signed-off-by: Oleksii Orel <[email protected]>
eclipse-che · Sep 9, 2021 · dd7f466 · dd7f466
1 parent 9efeb04
commit dd7f466
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/packages/common/src/helpers/__tests__/errors.spec.ts b/packages/common/src/helpers/__tests__/errors.spec.ts
@@ -14,7 +14,7 @@ import axios, { AxiosError, AxiosResponse } from 'axios';
 import { HttpError } from '@kubernetes/client-node';
 import AxiosMockAdapter from 'axios-mock-adapter';
 import * as http from 'http';
-import { getMessage } from '../errors';
+import { getMessage, isError } from '../errors';
 
 let mockAxios = new AxiosMockAdapter(axios);
 
@@ -28,10 +28,26 @@ describe('Errors helper', () => {
     mockAxios.resetHandlers();
   });
 
+  describe('Typeguards', () => {
+
+    it('should check if error', () => {
+      const message = 'Expected error.';
+      const error = new Error(message);
+      expect(isError(error)).toEqual(true);
+      expect(isError(message)).toEqual(false);
+    });
+
+  });
+
   it('should return default message', () => {
     expect(getMessage(undefined)).toEqual('Unexpected error.');
   });
 
+  it('should return message', () => {
+    const message = 'Expected error message.';
+    expect(getMessage(message)).toEqual(message);
+  });
+
   it('should return error message', () => {
     const message = 'Expected error.';
     const error = new Error(message);

diff --git a/packages/common/src/helpers/errors.ts b/packages/common/src/helpers/errors.ts
@@ -54,6 +54,10 @@ export function getMessage(error: unknown): string {
     return error.message;
   }
 
+  if (typeof (error) === 'string') {
+    return error;
+  }
+
   console.error('Unexpected error:', error);
   return 'Unexpected error. Check DevTools console and network tabs for more information.'
 }

diff --git a/packages/dashboard-frontend/src/containers/FactoryLoader/index.tsx b/packages/dashboard-frontend/src/containers/FactoryLoader/index.tsx
@@ -268,12 +268,7 @@ export class FactoryLoaderContainer extends React.PureComponent<Props, State> {
         this.resolvePrivateDevfile(e.attributes.oauth_authentication_url, location);
         return;
       }
-
-      let alertMessage = 'Failed to resolve a devfile.';
-      if (common.helpers.errors.isError(e)) {
-        alertMessage += ' ' + common.helpers.errors.getMessage(e);
-      }
-      this.showAlert(alertMessage);
+      this.showAlert(`Failed to resolve a devfile. ${common.helpers.errors.getMessage(e)}`);
       return;
     }
     if (this.factoryResolver.resolver?.location !== location) {