[703] fix NPE when no build binaries on system PATH

[ghentschke]

• fixes NPE when new cmake project has been created while there are no C/C++ build binaries on the PATH environment variable. The NPE has been thrown when the children of the project should be fetched (e.g. in project explorer view)

fixes #703

[jonahgraham]

This change is fine - but that relatively new method (getBinaryParserIds) is supposed to return non-null and something violated API by it returning null here.

It would be good to identify how getBinaryParserIds is returning null here.

[ghentschke]

Its the org.eclipse.cdt.core.build.ErrorBuildConfiguration.getBinaryParserIds() which returns null

[jonahgraham]

I continue to be fine with this - and leave it up to you how much more you want to dig into the history here.

I was surprised that I allowed through an auto generated method comment in #75 - that was until I looked at the whole file to be reminded of this unexpected design decision to explicitly allow NPEs:

cdt/core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/build/ErrorBuildConfiguration.java

Lines 35 to 36 in bfa8700

	* TODO leaving most of the implementation as default. I don't think any of these methods get called when
	* we're in this error state but we'll keep an eye open for NPE's and bad behavior.

[ghentschke]

Thank you @jonahgraham

[ghentschke]

I was surprised that I allowed through an auto generated method comment in #75 - that was until I looked at the whole file to be reminded of this unexpected design decision to explicitly allow NPEs:

I had the same thoughts as I saw the lazy handling ;-)