Postpone build container creation to build start. Fixes possible Ecli… #433
Conversation
ewaterlander
force-pushed
the
buildcontainer
branch
2 times, most recently
from
afc45d7 to
c8c41dd
Compare
|
I don't see a relation with the failure and my change. |
|
Sorry - the build failure is not related to you. Something in our dependencies changed in the last few days. I will look at this soon. |
…pse freeze. The creation of the build container for Core Build projects is postponed to the start of the build process. StandardBuildConfiguration getBuildContainer and setBuildContainer have been cleaned up. CBuildConfiguration creation is started via CBuildConfigurationManager.getBuildConfiguration(IBuildConfiguration) which holds a lock on the HashMap 'configs'. Creation of StandardBuildConfiguration triggered, via applyProperties and getBuildContainer(), a Folder.create which loops back to CBuildConfigurationManager.getBuildConfiguration(). For detailed traces see eclipse-cdt#424 Fixes issue eclipse-cdt#424
jonahgraham
force-pushed
the
buildcontainer
branch
from
c8c41dd to
ac37e38
Compare
There was a problem hiding this comment.
I have rebased on main to pick up snakeyaml fix submitted in #436
Once the build succeeds I can merge this.
| if (!(container instanceof IProject) && !container.exists()) { | ||
| IContainer parent = container.getParent(); | ||
| if (!(parent instanceof IProject) && !parent.exists()) { | ||
| createBuildContainer(parent, monitor); |
There was a problem hiding this comment.
This looks like it also handles the case of more than 2 layers of containers. Thanks
|
Thanks @ewaterlander PS I changed the commit text and description from |
Thanks Jonah. |
jonahgraham
added
the
noteworthy
…pse freeze.
The creation of the build container for Core Build projects is postponed to the start of the build process.
StandardBuildConfiguration getBuildContainer and setBuildContainer have been cleaned up.
CBuildConfiguration creation is started via
CBuildConfigurationManager.getBuildConfiguration(IBuildConfiguration) which holds a lock on the HashMap 'configs'. Creation of StandardBuildConfiguration triggered, via applyProperties and getBuildContainer(), a Folder.create which loops back to CBuildConfigurationManager.getBuildConfiguration(). For detailed traces see #424
Fixes #424