Update to using direct from maven dependencies where possible #387
Conversation
|
Thank you for working on this @jonahgraham |
Yes. I need to figure out how to document the updated steps now - but we have always updated all the dependencies in one PR, it just used to be by changing the Orbit version. As most of the versions in the target file were |
|
I don't understand why license check is failing here for icu, it passes in platform for AFAICT the same content. |
|
I don't see how it is passing for Eclipse Platform (e.g. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/4846605691/jobs/8636246851) - because I don't see license vetting having been done for 73.1 in iplab. The 72.1 is there in https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/4354 We aren't releasing for a couple of months still, so this issue on its own isn't going to hold up merging this. But I would like to understand the flow of what is going wrong with this new check added in #386. Until now I have run license tool and manually verified the not automatically verified parts (e.g. https://ci.eclipse.org/cdt/job/run-dash-licenses/job/cdt_11_1/1/ for 11.1) |
|
Before this can be merged we also need the PGP signing which has a dependency on EF Helpdesk #3070 |
jonahgraham
force-pushed
the
deps-maven
branch
2 times, most recently
from
8297382
to
5e84957
Compare
|
/request-license-review |
Workflow run (with attached summary files): |
|
/request-license-review |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
jonahgraham
force-pushed
the
deps-maven
branch
8 times, most recently
from
0b81d50
to
ed42511
Compare
|
Current state of this branch (maven-deps) is that I cannot sign because of |
So I am working on refreshing our custom images, but for 2023-06 I won't get this integrated. |
Snakeyml recentlyish came out with 2.0 version and more recently TM4E started using the 2.0 version. As TM4E snapshots are in our target platform we started failing as we started wiring to the newer version due to a missing underbound on our dependency. A separate task of updating to recent snakeyaml will be done as part of eclipse-cdt#387
Snakeyml recentlyish came out with 2.0 version and more recently TM4E started using the 2.0 version. As TM4E snapshots are in our target platform we started failing as we started wiring to the newer version due to a missing underbound on our dependency. A separate task of updating to recent snakeyaml will be done as part of #387
jonahgraham
force-pushed
the
deps-maven
branch
3 times, most recently
from
e98c3f7
to
051588e
Compare
The target file has been formatted with the formatter in the Target editor when in the Source tab (Context menu -> Source -> Format).
Includes: - Sign all artifacts, particularly 3rd party with CDT's PGP key - Using maven version managed and updated by EF Webmasters - Update to latest SnakeYAML - Move some 3rd party dependencies to Import-Package (instead of Require-Bundle)
This is the next step in modernization and moving on from Orbit.
All the bundles that have fully OSGi bundles in maven are included in this update.
This PR contains the other update needed for 2023-06 M2
Part of #320