Improved GCCToolChain.stripCommand() #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCCToolChain.stripCommand() assumed that all resources are at the end of the command, like in the old version of GCCToolChain.getResourcesFromCommand() which was fixed in PR eclipse-cdt#311 (see commit a89ce59). Now stripCommand() is in line with getResourcesFromCommand().
|
The failing test is flaky and covered by #194 |
jonahgraham
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
I think this is fine - AFAICT there are no existing tests for any of this functionality so it is hard to verify if anything regresses because of this change.
If you want to reduce the chance of future regressions adding a unit test or two would be very welcome.
jonahgraham
added
editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCCToolChain.stripCommand() assumed that all resources are at the end of the command, like in the old version of
GCCToolChain.getResourcesFromCommand() which was fixed in PR #311 (see commit a89ce59). Now stripCommand() is in line with getResourcesFromCommand().