Support IEditorAssociationOverride (#341) #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonahgraham can you please review? |
|
Sorry I haven't reviewed yet. I hope to get to it soon. |
ghentschke
force-pushed
the
support-IEditorAssociationOverride
branch
from
6df3840
to
9cb03ad
Compare
jonahgraham
force-pushed
the
support-IEditorAssociationOverride
branch
from
9cb03ad
to
69c46ff
Compare
|
I have a concern that there is some weird corner case that the behaviour changes unexpectedly, but if the automated tests don't cover it I am happy to merge this. The code on selecting editors is way too complicated and I am suspicious at the value of most of that complexity. This new code will be the taken path most of the time now, which is good. I force pushed to fix the whitespace error and I will merge once we get a clean run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #341