Restore counting iterations in computeContainsDeclaration cycle detector #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-garrison
force-pushed
the
pr/restore-counting-iterations-in-compute-contains-declaration
branch
from
2b840cb
to
df54384
Compare
i-garrison
changed the title
jonahgraham
approved these changes
Mar 16, 2023
A follow-up change to bug 509898 missed actually incrementing the counter, restore it now. Fixes: 5462bac ("Bug 509898 - IndexFileSet.containsDeclaration is slow and is causing UI freezes")
|
I have rebased the change to make sure that it builds cleanly on main now that we released 11.1.0. Normally this is just a check that code cleanliness still passes, especially bundle version numbers are where they are supposed to be. |
jonahgraham
force-pushed
the
pr/restore-counting-iterations-in-compute-contains-declaration
branch
from
df54384
to
f76fb34
Compare
It was by code inspection. I was looking at the issue where index lookup returns too many bindings for class declaration/definition which makes lookup ambiguous, but apparently some of those bindings are not reachable from current AST. |
i-garrison
deleted the
pr/restore-counting-iterations-in-compute-contains-declaration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up change to bug 509898 missed actually incrementing the counter, restore it now.
Fixes: 5462bac ("Bug 509898 - IndexFileSet.containsDeclaration is slow and is causing UI freezes")