Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #167 - Core Build Makefile project build output folder. #314

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Issue #167 - Core Build Makefile project build output folder. #314

merged 1 commit into from
Mar 17, 2023

Conversation

ewaterlander
Copy link
Contributor

@ewaterlander ewaterlander commented Mar 10, 2023 •
edited by jonahgraham
Loading

Issue #167 - Core Build Makefile project build output folder.

Fixes #167

@ewaterlander ewaterlander mentioned this pull request Mar 10, 2023
Closed
@github-actions
Copy link

github-actions bot commented Mar 10, 2023 •
edited
Loading

Test Results

     592 files       592 suites   16m 8s ⏱️
10 065 tests 10 043 ✔️ 22 💤 0 ❌
10 187 runs  10 165 ✔️ 22 💤 0 ❌

Results for commit af1aa8d.

♻️ This comment has been updated with latest results.

@jonahgraham jonahgraham added this to the 11.2.0 milestone Mar 14, 2023
@jonahgraham
Copy link
Member

I have seen your PR but haven't had a chance to review yet. I will as soon as I can.

jonahgraham pushed a commit to jonahgraham/cdt that referenced this pull request Mar 16, 2023
@ewaterlander @jonahgraham
Changed the template application to Hello World.
bd255e2 
This provides a more useful template when making a simple Makefile
project.

Pulled out of eclipse-cdt#314
@jonahgraham jonahgraham mentioned this pull request Mar 16, 2023
Merged
@jonahgraham
Copy link
Member

I have rebased the change to make sure that it builds cleanly on main now that we released 11.1.0. Normally this is just a check that code cleanliness still passes, especially bundle version numbers are where they are supposed to be.

I also split out the hello_world to a separate PR as it looks unrelated See #327

@jonahgraham
Copy link
Member

@mbooth101 do you have time to review this change? If it still contains two unrelated changes, please feel free to ask @ewaterlander to split them up if that helps reviewing, I already split part out of the original commit into #327

jonahgraham pushed a commit to jonahgraham/cdt that referenced this pull request Mar 16, 2023
@ewaterlander @jonahgraham
Changed the template application to Hello World.
a455165 
This provides a more useful template when making a simple Makefile
project.

Pulled out of eclipse-cdt#314
jonahgraham pushed a commit that referenced this pull request Mar 16, 2023
@ewaterlander @jonahgraham
Changed the template application to Hello World.
50bddd8 
This provides a more useful template when making a simple Makefile
project.

Pulled out of #314
@ewaterlander
Copy link
Contributor Author

@mbooth101 do you have time to review this change? If it still contains two unrelated changes, please feel free to ask @ewaterlander to split them up if that helps reviewing, I already split part out of the original commit into #327

I will split the patch.

@ewaterlander
Issue eclipse-cdt#167 - Core Build Makefile project build output folder.
af1aa8d 
* Issue Issue eclipse-cdt#167 was partly solved by PR eclipse-cdt#192 (commit 7911ac8).
  This change fixes the problem that after closing and opening a
  Makefile project the wrong build output location was used for the
  default Run configuration.
  The cause was that StandardBuildConfiguration.buildContainer was
  null after opening the project.

Fixes eclipse-cdt#167
@ewaterlander ewaterlander force-pushed the build_output branch 2 times, most recently from 562e46d to af1aa8d Compare March 17, 2023 10:01
@jonahgraham
Copy link
Member

@mbooth101 do you have time to review this change? If it still contains two unrelated changes, please feel free to ask @ewaterlander to split them up if that helps reviewing, I already split part out of the original commit into #327

I will split the patch.

With the patch split this part is trivial to review now. Thanks.

@jonahgraham jonahgraham merged commit 2b297c4 into eclipse-cdt:main Mar 17, 2023
@ewaterlander ewaterlander deleted the build_output branch March 23, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

@mbooth101 mbooth101 Awaiting requested review from mbooth101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.2.0
Development

Successfully merging this pull request may close these issues.

Core build launch configurations are not persistent.
2 participants
@ewaterlander @jonahgraham