Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up for synchronization of LaunchBarManager.descriptors #277

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

trancexpress
Copy link
Contributor

This change makes LaunchBarManager.descriptors a synchronized map, slightly reducing the extra code and complexity added for #262.

Signed-off-by: Simeon Andreev [email protected]

This change makes LaunchBarManager.descriptors a synchronized map,
slightly reducing the extra code and complexity added for eclipse-cdt#262.

Signed-off-by: Simeon Andreev <[email protected]>
@trancexpress
Copy link
Contributor Author

@jonahgraham can you take a look? Its not much of a clean-up, the rest of the descriptors use still requires the new synchronized blocks (since its either iteration of the keys or values, or its several operations to ensure the order in the linked list).

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Test Results

   539 files     539 suites   13m 50s ⏱️
9 636 tests 9 614 ✔️ 22 💤 0
9 647 runs  9 625 ✔️ 22 💤 0

Results for commit 16de2ed.

@jonahgraham jonahgraham merged commit eb083f8 into eclipse-cdt:main Feb 6, 2023
@jonahgraham
Copy link
Member

Thanks @trancexpress for the cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants