Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance memory data initialization checks #138

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

jld01
Copy link
Contributor

@jld01 jld01 commented Nov 6, 2022

No description provided.

@jld01 jld01 added this to the 11.0.0 milestone Nov 6, 2022
@jld01 jld01 self-assigned this Nov 6, 2022
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Test Results

     635 files       635 suites   51m 24s ⏱️
11 384 tests 11 250 ✔️ 133 💤 1
11 347 runs  11 213 ✔️ 133 💤 1

For more details on these failures, see this check.

Results for commit ef6ac2b.

Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - BTW the failed test (testClassInUnnamedNamespace) is one of those covered in #117 and will hopefully never be seen again once I merge #120 :-)

@jld01
Copy link
Contributor Author

jld01 commented Nov 6, 2022

Thank you for the reviews @ruspl-afed and @jonahgraham.

@jld01 jld01 merged commit 1bb0cf0 into eclipse-cdt:main Nov 6, 2022
@jld01 jld01 deleted the memory-checks branch November 6, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants