Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started documentation update. #1056

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ewaterlander
Copy link
Contributor

  • Put Core Build and Managed Build items in separate topics.
  • Added two images to Creating a CMake project.
  • Added new pages about creating a CBS Makefile project, using existing code, and the launch bar.
  • Renamed "Creating a simple application" to "Creating a Managed Build System Makefile project" and replaced two images.
  • Removed "Creating a Makefile project", because it was duplicate information.

Fixes #992

@ewaterlander
Copy link
Contributor Author

Hi @jonahgraham @jld01 @betamaxbandit ,

Would you like to review this change? It is not finished yet. I'm going to add topics about Building, Running, and Debugging. You can start adding comments.

I separated CBS and MBS.

image

Copy link

github-actions bot commented Jan 23, 2025

Test Results

   601 files  ±0     601 suites  ±0   13m 28s ⏱️ +4s
10 200 tests ±0  10 176 ✅  - 1  23 💤 ±0  1 ❌ +1 
10 238 runs  ±0  10 214 ✅  - 1  23 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 378d553. ± Comparison against base commit 5e62200.

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Member

I'll have a look soon - in the meantime since I don't have an auto comment, the docs are available from this build in https://github.com/eclipse-cdt/cdt/actions/runs/12933695063?pr=1056 (docs link near the bottom)

Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks very good, I think how you have split it up is very useful.

image:launchbar.png[Launch Bar]

. Build button, to launch a build.
. Run button, to launch a run. This button will change to a Debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention profile mode somewhere here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doubting about mentioning it in "getting started". The Profile mode is not in the launch mode selector before you run profiling. Profiling only works properly in Makefile projects, not in CMake. And you need to have the profiling plugin installed before it is available at all. I think it is more an advanced topic.

@jld01 jld01 self-requested a review January 23, 2025 21:17

== Launch Bar

CBS projects rely on the *LaunchBar*. Make sure the launch bar plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CBS projects rely on the *LaunchBar*. Make sure the launch bar plugin
Core Build System (CBS) projects rely on the *Launch Bar*. Make sure the _LaunchBar UI_ feature

Comment on lines +33 to +34
This tutorial describes how to use existing code for Core Build System
projects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This tutorial describes how to use existing code for Core Build System
projects.
This tutorial describes how to create a new Core Build System
project for use with existing code.

Comment on lines +39 to +42
=== Using an existing CMake project

To create an empty CMake project select the template *Empty or Existing CMake
Project* in the *New C/{cpp} Project* wizard.
Copy link
Contributor

@jld01 jld01 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clarify the distinction between a "CMake project" (IDE independent source code) and a "CMake project" (metadata created by CDT).


image:cbs_empty_cmake_project.png[Empty or Existing CMake Project]

Then in the *New CMake Project* wizard deselect *Use default location*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then in the *New CMake Project* wizard deselect *Use default location*
In the *New CMake Project* wizard deselect *Use default location*

Comment on lines +54 to +56
=== Using an existing Makefile project

Create a Makefile project as described in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, distinguish the two uses of "Makefile project" here.

Comment on lines +60 to +61
In the *New Makefile Project* wizard deselect *Use default location*
and set the location of the existing code, and deselect *Create Hello
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the *New Makefile Project* wizard deselect *Use default location*
and set the location of the existing code, and deselect *Create Hello
In the *New Makefile Project* wizard deselect *Use default location*,
set the location of the existing code, and deselect *Create Hello

Comment on lines +41 to +42


Copy link
Contributor

@jld01 jld01 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think multiple empty lines (here and elsewhere) are being interpreted as the end of the numbered list. So the next numbered list item will be item "1" again. Try a single empty line only.

Copy link
Contributor

@jld01 jld01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on your work-in-progress, @ewaterlander. Great to see the documentation being updated.

@ewaterlander
Copy link
Contributor Author

I added three new topics: Building, Running, and Debugging a project. Now the change is complete. I will process the comments on Monday. Thanks. Have a nice weekend!

* Put Core Build and Managed Build items in separate topics.
* Added two images to Creating a CMake project.
* Added new pages about creating a CBS Makefile project, using
  existing code, launch bar, building, running, and debbuggin
  a project.
* Renamed "Creating a simple application" to "Creating a Managed Build
  System Makefile project" and replaced two images.
* Removed "Creating a Makefile project", because it was duplicate
  information.

Fixes eclipse-cdt#992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CDT user manual chapter "Getting Started" needs to be updated.
3 participants