Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Compilation Database Generator properties page is visible in non C/C++ projects #847

Closed
ghentschke opened this issue Jun 28, 2024 · 3 comments · Fixed by #848 or #850
Closed

JSON Compilation Database Generator properties page is visible in non C/C++ projects #847

ghentschke opened this issue Jun 28, 2024 · 3 comments · Fixed by #848 or #850

Comments

@ghentschke
Copy link
Contributor

Describe the bug
The JSON Compilation Database Generator properties page is visible in non C/C++ projects as well:

To Reproduce
Steps to reproduce the behavior:

  1. Create a non C/C++ project in Eclipse IDE with CDT
  2. Open Properties of that project
  3. See error

Expected behavior
The JSON Compilation Database Generator properties page should not be visible/enabled in non C/C++ projects.

Screenshots
image

Version Information (please complete the following information):
ghentschke added a commit to ghentschke/cdt-changes that referenced this issue Jun 28, 2024
@ghentschke
Add enabled to JSON Compilation Database Generator prop page (eclipse…
a4b7d3b 
…-cdt#847)

Show the JSON Compilation Database Generator properties page only for
managed build projects.

fixes eclipse-cdt#847
@ghentschke ghentschke mentioned this issue Jun 28, 2024
Merged
ghentschke added a commit to ghentschke/cdt-changes that referenced this issue Jun 28, 2024
@ghentschke
Add enabled to JSON Compilation Database Generator prop page (eclipse…
7a80091 
…-cdt#847)

Show the JSON Compilation Database Generator properties page only for
managed build projects.

fixes eclipse-cdt#847
@jonahgraham
Copy link
Member

I am targetting this for the 10.6 branch and I will cherry-pick it to that branch soon.

@jonahgraham jonahgraham reopened this Jun 28, 2024
github-actions bot pushed a commit that referenced this issue Jun 28, 2024
@ghentschke
Add enabled to JSON Compilation Database Generator prop page (#847) (#…
91c4a6f 
…848)

Show the JSON Compilation Database Generator properties page only for
managed build projects.

fixes #847

(cherry picked from commit 597eda2)
@jonahgraham jonahgraham linked a pull request Jun 28, 2024 that will close this issue
[cdt_11_6] Add enabled to JSON Compilation Database Generator prop page (#847) (#848) #850
Merged
jonahgraham added a commit that referenced this issue Jun 28, 2024
@github-actions @ghentschke @jonahgraham
[cdt_11_6] Add enabled to JSON Compilation Database Generator prop pa…
54e9f2f 
…ge (#847)

Show the JSON Compilation Database Generator properties page only for
managed build projects.

fixes #847

(cherry picked from commit 597eda2)

Co-authored-by: G. Hentschke <[email protected]>
Co-authored-by: Jonah Graham <[email protected]>
@ghentschke
Copy link
Contributor Author

IMO this can be closed?

@jonahgraham
Copy link
Member

IMO this can be closed?

The 11.6.1 release will be out soon and includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jonahgraham @ghentschke