-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest direct-from-maven dependencies #366
Conversation
See also eclipse-cdt/cdt#894 which similar changes. |
@merks do you think it may be better to switch from direct maven to Orbit dependencies here? What are the latest trends at the moment? |
The question is a little bit politically loaded so I will tread carefully so as not to offend alternative valid points of view on the subject.
Neutral points that apply to both cases:
For dependencies that need BND instructions, we have a significant problem if different projects wrap the same artifact in different ways while producing the same bundle symbolic name. Even if different BSNs are produced, we end up with "hidden" duplicates that will presumably export the same Java packages quite likely leading to wiring problems in a composed end result like SimRel. Hence the rule that only direct-from-maven dependencies that are directly available as OSGi bundles are permitted in SimRel. The significant question is, how best to keep dependencies up-to-date?
I will leave it up to projects to decide what is best for them. My personal bias is really not relevant. |
Thank you for such an exhaustive answer @merks |
The Tycho Target update can handle both, maven and P2 locations. Beside that, the most important part is how dependencies are referenced so they should
then the actual used version to build is not that important and P2 can simply kick out older versions itself. |
FYI, in this case category.xml included a dependency bundle with an exact version. I think that wasn't necessary... |
To be honest, I am not very familiar with the dependency management. Since the cdt-lsp project is very close to cdt, we should discuss this issue with @jonahgraham how to handle that in the future in cdt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@merks Thank you! |
No description provided.