Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the org.eclipse.birt.engine.runtime product #1861

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Aug 18, 2024

  • Include only the org.eclipse.birt.osgi.runtime feature.

- Include only the org.eclipse.birt.osgi.runtime feature.
@merks merks self-assigned this Aug 18, 2024
@merks
Copy link
Contributor Author

merks commented Aug 18, 2024

@speckyspooky

I believe this produces the same runtime contents as before. It's more logical and simpler that runtime content is defined by the org.eclipse.birt.osgi.runtime feature.

@speckyspooky
Copy link
Contributor

@merks
I like your simplefication and after the build I can test the OSGi-version with my tomcat.

@speckyspooky speckyspooky added the Dependencies Pull requests that update a dependency file label Aug 18, 2024
@speckyspooky speckyspooky added this to the 4.17 milestone Aug 18, 2024
@merks merks merged commit 7e81de3 into eclipse-birt:master Aug 18, 2024
3 checks passed
@merks merks deleted the pr-simply-runtime branch August 18, 2024 12:36
@merks
Copy link
Contributor Author

merks commented Aug 20, 2024

@speckyspooky

I interpret silence as "I tested it and it there are no problems.

I'd like to build our first milestone soon based on the SimRel m3 content that will be finalized this week. Of course it's best if that version is known to function well. 😄

@speckyspooky
Copy link
Contributor

@merks
No, the silence was due to my vacation an some actions with my family 😄
But now I was able to test the latest build of OSGi with my windows system, tomcat 9.x.
The demo reports can be created successfully, tested with standard reports and reports with charts.

Technical details:

  • MS Windows 11
  • Tomcat 9.0.93
  • BIRT 4.17 - build N202408181237

From my side we can go ahead.

@merks
Copy link
Contributor Author

merks commented Aug 20, 2024

Sorry you’re we’re all entitled and have earned a personal life. Thanks for the confirmation.

@speckyspooky
Copy link
Contributor

No problem, in the most cases I find a little bit time :o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants