Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the PDF options to provide the control option to include the CIDSet of a font (#1817) #1823

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Enhance the PDF options to provide the control option to include the CIDSet of a font (#1817) #1823

merged 2 commits into from
Aug 1, 2024

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky speckyspooky added this to the 4.17 milestone Jul 31, 2024
@speckyspooky speckyspooky added the Enhancement Small change to improve the current supported functionality label Jul 31, 2024
@speckyspooky speckyspooky self-assigned this Jul 31, 2024
@speckyspooky speckyspooky requested a review from merks August 1, 2024 03:05
hvbtup
hvbtup approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@hvbtup hvbtup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

merks
merks requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimally use boolean instead of Boolean. Shortening the name seems good too.

....report.engine.emitter.pdf/src/org/eclipse/birt/report/engine/emitter/pdf/PDFPageDevice.java Outdated Show resolved Hide resolved
....report.engine.emitter.pdf/src/org/eclipse/birt/report/engine/emitter/pdf/PDFPageDevice.java Outdated Show resolved Hide resolved
....report.engine.emitter.pdf/src/org/eclipse/birt/report/engine/emitter/pdf/PDFPageDevice.java Outdated Show resolved Hide resolved
@speckyspooky speckyspooky requested a review from merks August 1, 2024 18:17
merks
merks approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. 😊

@speckyspooky speckyspooky merged commit 3884be4 into eclipse-birt:master Aug 1, 2024
3 of 6 checks passed
@wimjongman wimjongman linked an issue Sep 16, 2024 that may be closed by this pull request
PDF/A-3 support, validation fails #1817
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvbtup hvbtup hvbtup approved these changes

@merks merks merks approved these changes

Assignees

@speckyspooky speckyspooky

Labels
Enhancement Small change to improve the current supported functionality
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.

PDF/A-3 support, validation fails
3 participants
@speckyspooky @merks @hvbtup