Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance comments, raw types and other small hints to reduce java warnings #1814

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Enhance comments, raw types and other small hints to reduce java warnings #1814

merged 1 commit into from
Jul 22, 2024

Conversation

speckyspooky
Copy link
Contributor

The PR includes some changes to reduce the java warnings based on optimization of:

  • java documentation
  • use raw types with type operator
  • replace deprecated methods

@speckyspooky speckyspooky added Dependencies Pull requests that update a dependency file Documentation labels Jul 21, 2024
@speckyspooky speckyspooky added this to the 4.17 milestone Jul 21, 2024
@speckyspooky speckyspooky requested a review from merks July 21, 2024 15:26
@merks
Copy link
Contributor

merks commented Jul 21, 2024

FYI. It’s hard to review from my phone. I’ll look tomorrow.

merks
merks reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still quite a bit of room for improvement and some of the return type especially are poor.

.../uk.co.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/ExcelEmitter.java Show resolved Hide resolved
...org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/DesignElementHandle.java Outdated Show resolved Hide resolved
...org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/DesignElementHandle.java Outdated Show resolved Hide resolved
...org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/DesignElementHandle.java Show resolved Hide resolved
...org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/DesignElementHandle.java Show resolved Hide resolved
...org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/DesignElementHandle.java Outdated Show resolved Hide resolved
...org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/DesignElementHandle.java Outdated Show resolved Hide resolved
....eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/ReportDesignHandleImpl.java Outdated Show resolved Hide resolved
....eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/ReportDesignHandleImpl.java Outdated Show resolved Hide resolved
@speckyspooky speckyspooky force-pushed the enhance_design_handle_remove_warnings branch from 52e86d7 to a7d8f6a Compare July 22, 2024 18:32
@speckyspooky speckyspooky requested a review from merks July 22, 2024 18:57
merks
merks approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🙏

@speckyspooky speckyspooky merged commit 5f379b5 into eclipse-birt:master Jul 22, 2024
3 of 7 checks passed
@speckyspooky speckyspooky self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks approved these changes

Assignees

@speckyspooky speckyspooky

Labels
Dependencies Pull requests that update a dependency file Documentation
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.
2 participants
@speckyspooky @merks