Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eclipse warnings and add java documentation, part 2 (#1670) #1674

Merged

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky speckyspooky added this to the 4.16 milestone May 8, 2024
@speckyspooky speckyspooky self-assigned this May 8, 2024
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

*
* @return
* @return Return the root content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future it is not needed to add Return to @return

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will think on it!

@speckyspooky speckyspooky merged commit 3c141a3 into eclipse-birt:master May 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants