Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance designer viewer with spaces into path (#1466) #1621

Conversation

speckyspooky
Copy link
Contributor

Enhance designer viewer with spaces into path (#1466)

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. 😎 I think that will do the trick.

@speckyspooky
Copy link
Contributor Author

@merks With your hint & support!
But currently the build isn't runable and I cannot see the reason of the issue to my change.
Do you know is it temporary or what can I do here... - this is for me the nightmare to find unspeakable messages w/o a clear hint of the reason.

build-error

@merks
Copy link
Contributor

merks commented Apr 3, 2024

That’s the same problem mentioned here

#1618 (comment)

maybe it’s because of a new orbit milestone today

I will need to investigate.

I really don’t get paid enough. 👿

@speckyspooky
Copy link
Contributor Author

Ok, I saw the comment before and thougth there that it is coming from the local build.
But it seems that we have it in generally.

Please let me know if I can assist you or support you with testing or research-details let me know!

@speckyspooky
Copy link
Contributor Author

The same issue was documented last year here #1492 & #1493

@merks merks force-pushed the enhance_designer_viewer_with_spaces_into_path branch from 5311d17 to 4bf4013 Compare April 4, 2024 07:37
@merks merks merged commit 0d28cac into eclipse-birt:master Apr 4, 2024
3 checks passed
@speckyspooky speckyspooky added this to the 4.16 milestone Apr 4, 2024
@speckyspooky speckyspooky added the BugFix Change to correct issues label Apr 4, 2024
@speckyspooky speckyspooky self-assigned this Apr 4, 2024
@speckyspooky
Copy link
Contributor Author

The retest of the nithgly build wasn't successful. The reason of it is that the changed code isn't currently included.
I have recompiled the "viewer.jar" and the change isn't included.

I hope that the change is added at the next nightly build.

@merks
Copy link
Contributor

merks commented Apr 7, 2024

The build failed with a heap space error:

https://ci.eclipse.org/birt/job/build/job/master/

That seems to be an intermittent infrastructure problem. I kicked another build:

https://ci.eclipse.org/birt/job/build/job/master/

@speckyspooky
Copy link
Contributor Author

Oh yes, I had this issue too on Friday evening an on Saturday morning was the problem away.
Thanks for your re-start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix Change to correct issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants