Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excel-issue of removed row then remove also regsitered merge regions from sheet (#1455) #1467

Merged

Conversation

speckyspooky
Copy link
Contributor

Fix the excel-issue if an blank row with merged cells will be removed then remove the registered merge area from the excel-sheet and also an additional double check is added to avoid overlapping merge registrations on the excel-sheet (#1455)

then remove the registered merge area from the excel-sheet and also an
additional double check is added to avoid overlapping merge
registrations on the excel-sheet (eclipse-birt#1455)
@speckyspooky speckyspooky added this to the 4.14 milestone Oct 30, 2023
@speckyspooky speckyspooky added the BugFix Change to correct issues label Oct 30, 2023
@speckyspooky speckyspooky self-assigned this Oct 30, 2023
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@speckyspooky speckyspooky merged commit 2956700 into eclipse-birt:master Oct 31, 2023
3 checks passed
@speckyspooky speckyspooky deleted the Fix_xlsx_merge_region_issue branch March 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix Change to correct issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants