Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of images handling of HTML embedded images which cause NullPointerException (#1436) #1440

Conversation

speckyspooky
Copy link
Contributor

Fix of images which are embedded like URL on an html document which is embedded into a birt report element (e.g. dynamic text)

@speckyspooky
Copy link
Contributor Author

@wimjongman
Hello Wim, this is a fix which should be included into BIRT4.14 to avoid the according exception.

By the way, I plan no further checkin for 4.14 only if we should get some bug notifications.
Other changes will be moved after the release of 4.14 (e.g. change of the font-mapping).

@reiner-killet
Copy link

reiner-killet commented Sep 29, 2023

Is fix #1440 contained in the nightly build (https://download.eclipse.org/birt/updates/nightly/latest/index.html)?
I downloaded the RCP designer for Windows from there and the same error message still occurs.

@speckyspooky
Copy link
Contributor Author

The fix is currently not included to the nightly built because I wait of the approval of @wimjongman
If he has done the quality check I will consider his response and with the approval I can merge it to the master and afterwards it will go into the nightly built.

Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thomas.

@speckyspooky speckyspooky merged commit a6c487d into eclipse-birt:master Sep 29, 2023
1 check passed
@speckyspooky speckyspooky deleted the Fix_background_image_null_pointer branch March 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix Change to correct issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants