Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cassandra Scripted Data Source & the Hector PlugIn (#1418) #1419

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Remove Cassandra Scripted Data Source & the Hector PlugIn (#1418) #1419

merged 4 commits into from
Sep 18, 2023

Conversation

speckyspooky
Copy link
Contributor

According to the issue-ticket (#1418) the "Cassandra Scripted Data Source" and the Hecotr PlugIn will be removed.

@speckyspooky
Copy link
Contributor Author

Hello Wim & Henning, I have you both added to review.

  • Henning I used your "data source extraction" verified the details of Cassandra and removed the Cassandra-(Hector)-parts. So I would think you will remember on the most of the removed parts.

  • Wim it would be nice too if you can take a look into it especially in your role as project leader before the option will be removed.

@speckyspooky speckyspooky self-assigned this Sep 17, 2023
@speckyspooky speckyspooky added this to the 4.14 milestone Sep 17, 2023
@speckyspooky speckyspooky added the Dependencies Pull requests that update a dependency file label Sep 17, 2023
wimjongman
wimjongman approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the removal.

hvbtup
hvbtup approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@hvbtup hvbtup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes seem to correspond to what I did (for other DBs as well in my case).
Assuming that you also did a case-insensitive full text scan for CASSANDRA and HECTOR in the birt directory (both should return 0 results), +1 from me

@speckyspooky speckyspooky merged commit b1c2fcf into eclipse-birt:master Sep 18, 2023
1 check passed
This was referenced Sep 19, 2023
Closed
Closed
Closed
Closed
@speckyspooky speckyspooky mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvbtup hvbtup hvbtup approved these changes

@wimjongman wimjongman wimjongman approved these changes

Assignees

@speckyspooky speckyspooky

Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
4.14
Development

Successfully merging this pull request may close these issues.
3 participants
@speckyspooky @wimjongman @hvbtup