-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we get rid of releng? #989
Comments
Does this build also still succeed if you do not have a local .m2 repo? Do the bundles get referenced in the build output? |
The local build still succeeds if I delete the local .m2 directory. As for the other question: Which bundles, and which build output are you referring to? Neither build/org.eclipse.birt.releng.birtbuilder nor build/org.eclipse.birt.releng.util have any bundles (MANIFEST.MF files) nor any build output (target folders). |
Sorry, I meant: do you see any reference to the scripts in the build output. If not I say go ahead and delete them. We can always pull them back from git. |
The util project doesn't seem to be referenced anywhere other than projectSet.psf so I deleted it. Some files in the birtbuilder project are used as follows: projectSet.psf In birtbuilder I just deleted the .sh files and .xml files from the root directory. Everything still builds locally so I'm creating a pull request. |
Delete build/org.eclipse.birt.releng.util. Delete .sh and .xml files from build/org.eclipse.birt.releng.birtbuilder. Signed-off-by: Steve Schafer <[email protected]>
CLeanUp was done on PR #1316 |
In trying to track down where scripts are executed (both ant builds and other scripts), I see there are some scripts in build/org.eclipse.birt.releng.birtbuilder and build/org.eclipse.birt.releng.util that are not called anywhere. I deleted those files and my local build still succeeds. There is no pom.xml in birtbuilder or util. There is a pom.xml in birtbuilder/extras but it isn't referenced as a module in any other pom so it may not be called either. There are readme files in birtbuilder and util but they are very old (2007). Has all this releng code been replaced by maven and can we delete it?
The text was updated successfully, but these errors were encountered: