Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get rid of releng? #989

Closed
SteveSchafer-Innovent opened this issue Jun 1, 2022 · 5 comments
Closed

Can we get rid of releng? #989

SteveSchafer-Innovent opened this issue Jun 1, 2022 · 5 comments
Milestone

Comments

@SteveSchafer-Innovent
Copy link
Contributor

In trying to track down where scripts are executed (both ant builds and other scripts), I see there are some scripts in build/org.eclipse.birt.releng.birtbuilder and build/org.eclipse.birt.releng.util that are not called anywhere. I deleted those files and my local build still succeeds. There is no pom.xml in birtbuilder or util. There is a pom.xml in birtbuilder/extras but it isn't referenced as a module in any other pom so it may not be called either. There are readme files in birtbuilder and util but they are very old (2007). Has all this releng code been replaced by maven and can we delete it?

@wimjongman
Copy link
Contributor

Does this build also still succeed if you do not have a local .m2 repo? Do the bundles get referenced in the build output?

@SteveSchafer-Innovent
Copy link
Contributor Author

The local build still succeeds if I delete the local .m2 directory.

As for the other question: Which bundles, and which build output are you referring to? Neither build/org.eclipse.birt.releng.birtbuilder nor build/org.eclipse.birt.releng.util have any bundles (MANIFEST.MF files) nor any build output (target folders).

@wimjongman
Copy link
Contributor

Sorry, I meant: do you see any reference to the scripts in the build output. If not I say go ahead and delete them. We can always pull them back from git.

@SteveSchafer-Innovent
Copy link
Contributor Author

The util project doesn't seem to be referenced anywhere other than projectSet.psf so I deleted it. Some files in the birtbuilder project are used as follows:

projectSet.psf
build/org.eclipse.birt.build/repoGen.properties:readmeFile=../org.eclipse.birt.releng.birtbuilder/extras/runtime_readme.txt
build/birt-packages/birt-wtp-integration-sdk/pom.xml: copy html files from extras
build/birt-packages/birt-sample-plugins/pom.xml: copy html files from extras
build/birt-packages/birt-runtime-osgi/build.xml: copy genReport.sh from extras
build/birt-packages/birt-runtime-osgi/build.xml: copy genReport.bat from extras
build/birt-packages/birt-runtime-osgi/build.xml: copy html files from extras
build/birt-packages/birt-runtime-osgi/build.xml: copy runtime_readme.txt from extras
build/birt-packages/birt-charts/ChartSDK/pom.xml: copy html files from extras
build/birt-packages/birt-charts/pom.xml: copy html files from extras
build/birt-packages/birt-charts/ChartRuntime/pom.xml: copy html files from extras
build/birt-packages/birt-report-framework/pom.xml: copy html files from extras
build/birt-packages/birt-tests-suite/pom.xml: copy files from eclipse/buildConfigs/birt.tests/test.scripts
build/birt-packages/birt-report-framework-sdk/pom.xml: copy html files from extras
viewer/org.eclipse.birt.report.viewer/Build_Web_Viewer_Instruction_For_BIRT2.2.html: mentioned several places

In birtbuilder I just deleted the .sh files and .xml files from the root directory. Everything still builds locally so I'm creating a pull request.

SteveSchafer-Innovent added a commit to SteveSchafer-Innovent/birt that referenced this issue Jun 28, 2022
Delete build/org.eclipse.birt.releng.util.
Delete .sh and .xml files from build/org.eclipse.birt.releng.birtbuilder.

Signed-off-by: Steve Schafer <[email protected]>
@wimjongman wimjongman added this to the 4.13 milestone Jan 5, 2023
@wimjongman wimjongman modified the milestones: 4.13, 4.14 Mar 3, 2023
@speckyspooky
Copy link
Contributor

CLeanUp was done on PR #1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants