Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel, small images will be scalled to large images and lose the original size #1752

Closed
speckyspooky opened this issue Jun 24, 2024 · 2 comments
Assignees
Labels
Enhancement Small change to improve the current supported functionality
Milestone

Comments

@speckyspooky
Copy link
Contributor

The excel emitter (spudsoft) has an internal scaling to handle images in a special way for the excel output.
The excel which are too large and would overspan a cell will be shrinked, which is ok.
But images which have a smaller size like the cell will be grown.

The normal handling should be to keep the original image size of images which are smaller like the content cell.

Screen with 3 cases:

  • Case 1: standard image size without scalling - Ok
  • Case 2: large image which will be shrinked to th cell - Ok
  • Case 3: small image will be grown - Error

I will provide a PR for that. As fallback I will provide a user-property to restore the original behavior.

scaling-standard-spudsoft-excel

@speckyspooky speckyspooky added the Enhancement Small change to improve the current supported functionality label Jun 24, 2024
@speckyspooky speckyspooky added this to the 4.17 milestone Jun 24, 2024
@speckyspooky speckyspooky self-assigned this Jun 24, 2024
@speckyspooky speckyspooky changed the title Excel, small image will be scalled to large images and lose the original size Excel, small images will be scalled to large images and lose the original size Jun 24, 2024
@speckyspooky
Copy link
Contributor Author

The change is included at PR #1753

The new user property is ExcelEmitter.ImageScalingToCellDimension (default: false). If it is set to true all images will be scaled to the cell dimension also the small images.

Screen of new handling

enhanced-scaling-standard-spudsoft-excel

@speckyspooky
Copy link
Contributor Author

The change is merged to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Small change to improve the current supported functionality
Projects
None yet
Development

No branches or pull requests

1 participant