This repository has been archived by the owner on May 7, 2020. It is now read-only.
Remove interface inference #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2018 13:20
Signed-off-by: Simon Kaufmann <[email protected]>
Signed-off-by: Simon Kaufmann <[email protected]>
maggu2810
approved these changes
Feb 9, 2018
There was a problem hiding this comment.
As it is API breaking I would like to get a go from @kaikreuzer, too in front of merging.
Signed-off-by: Simon Kaufmann <[email protected]>
|
Thanks @maggu2810 - I though just realized that I had the types the wrong way round, therefore I had to push another commit. However, this doesn't really work nicely now with typed interfaces - see 3d2a698#diff-c0c87bcca219c6210ea787bcc45cf0a1R360. Do you maybe have an idea how this could be done nicely? |
Signed-off-by: Kai Kreuzer <[email protected]>
kaikreuzer
approved these changes
Feb 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen e.g. in openhab/org.openhab.binding.zigbee#47 (comment), the
SafeCaller.create(Class)method which infers the target interface has proven itself to be quite dangerous. Especially with target objects which are not in the framework's control (which is the main use-case for the SafeCaller), not all interfaces might be reachable from the current class loader. Hence I think it would be best to completely drop it. It was convenient, but not such a great improvement to start catching such exceptions and jumping through further hoops to make it possible.Signed-off-by: Simon Kaufmann [email protected]