This repository has been archived by the owner on May 7, 2020. It is now read-only.
notify handlers asynchronously so that longer running operations do not block us #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot block us Signed-off-by: Kai Kreuzer <[email protected]>
|
Doesn't this increase the potential change about a "not initialized anymore" call to the channel (un)linked method? |
Signed-off-by: Kai Kreuzer <[email protected]>
|
True. I've now moved the check into the runnable, so that it is checked immediately before the call - does that look better? |
|
Yes, the change is so the same as before, but the other issue is resolved. |
maggu2810
approved these changes
Nov 21, 2017
At least there is a pretty high probability that is is 😉 Let's see how the chances are in reality of running into a race condition at this place - the consequences would not be of real harm though, so I'm fine with it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ThingLinkManager might process events very slowly, which can be a cause for the issue described in #4591. Notifying the handlers asynchronously should solve this.
Signed-off-by: Kai Kreuzer [email protected]