This repository has been archived by the owner on May 7, 2020. It is now read-only.
Move update of thing to after update of item to ensure information is correctly presented #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correctly presented https://bugs.eclipse.org/bugs/show_bug.cgi?id=465079 Signed-off-by: Chris Jackson <[email protected]>
|
If changing the order solves your issue, we can merge it. But I think we need to continue the discussion on the bug. |
dnobel
added a commit
that referenced
this pull request
Apr 21, 2015
Move update of thing to after update of item to ensure information is correctly presented
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you update the label in the linked thing, the 'thing updated' event responds with the updated information being the same as the old information. This is because the thing is updated before the item, so we send incorrect information.
This PR reverses the order - the thing information is updated after the item, so the item changes are now correctly presented in the SSE event.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=465079
Signed-off-by: Chris Jackson [email protected]