Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Include org.eclipse.reddeer.jdt.junit bundle to the p2 update site. f… #2137

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Include org.eclipse.reddeer.jdt.junit bundle to the p2 update site. f… #2137

merged 1 commit into from
Aug 26, 2021

Conversation

odockal
Copy link
Collaborator

@odockal odockal commented Aug 26, 2021

…ixes #2136

Signed-off-by: Ondrej Dockal [email protected]

Pull Request Checklist

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?
  • Is copyright with correct year in new files?
  • Is there a JavaDoc in every class with description of a class and an author(and issue if suitable)?
  • Is there a link to github project issue? (if needed)

Testing

  • Does it work?
  • Are the tests green on Jenkins? Is there a link to Jenkins build?

@odockal odockal requested a review from jkopriva August 26, 2021 12:47
@odockal
Copy link
Collaborator Author

odockal commented Aug 26, 2021

@sbouchet If you could please take a look. Thanks!

sbouchet
sbouchet approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odockal odockal removed the request for review from jkopriva August 26, 2021 13:45
@odockal odockal merged commit b59638f into eclipse-archived:master Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odockal @sbouchet