fix(api): Fix users endpoints #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response of the query was missing the response type in apiDocs, and as a consequence, User type was not created to the API query client in the UI. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
requested review from
bs-ondem,
MarcelBochtler,
mnonnenmacher,
nnobelis,
oheger-bosch and
sschuberth
as code owners
Etsija
changed the title
The User data model includes also first name, last name and an e-mail address, but the request object for creating new users was missing those, in effect preventing to set the corr. attributes when creating new users. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
force-pushed
the
fix-list-users
branch
from
b3957ef
to
f7a01c5
Compare
Etsija
force-pushed
the
fix-list-users
branch
2 times, most recently
from
3a53f9c
to
234228b
Compare
|
@oheger-bosch could you maybe have a look? |
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
force-pushed
the
fix-list-users
branch
from
234228b
to
227e108
Compare
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
force-pushed
the
fix-list-users
branch
from
227e108
to
663280d
Compare
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
oheger-bosch
approved these changes
Oct 24, 2024
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 24, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 25, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 25, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 25, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Etsija
added a commit
that referenced
this pull request
Oct 25, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
PR #1278 extends user creation by adding optional first name, last name and email to the user information. Add these fields to the user creation form and mark them as optional. Signed-off-by: Jyrki Keisala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commits for details.