Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update drivers for isotope changes #3

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Update drivers for isotope changes #3

merged 5 commits into from
Apr 7, 2020

Conversation

apcraig
Copy link

@apcraig apcraig commented Apr 7, 2020 •
edited by eclare108213
Loading

PR checklist

  • Short (1 sentence) summary of your PR:
    Update drivers for isotope changes
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    untested
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig
Copy link
Author

apcraig commented Apr 7, 2020

This also includes a recent commit to the trunk which my sandbox is built off. If you prefer that I create a new sandbox directly from iso2 and resubmit the PR, I can. What I did is checkout master then pull iso2 into my sandbox which is why I'm ahead of iso2. Unclear to me what the best practice is. It's probably to have a clean iso2 version, although what I'm providing is a combination of my changes plus a pull from upstream. Again, let me know if you want me to resubmit.

@eclare108213
Copy link
Owner

It's probably better to create a clean sandbox, but let's not worry about it at this point, and just see what happens to the main PR once I merge this.

@eclare108213 eclare108213 merged commit 7dd83c2 into eclare108213:iso2 Apr 7, 2020
eclare108213 pushed a commit that referenced this pull request Nov 16, 2021
@phil-blain
ice_dyn_shared: add 'viscous_coeffs_and_rep_pressure_T' subroutine (#3)
50d67f8 
Add a subroutine mimicking what 'viscous_coeffs_and_rep_pressure' does,
but at a single location.

Name it '*_T' since it's going to be used to compute the viscous
coefficients and replacement pressure at the T point.
@apcraig apcraig deleted the iso2_drivers branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213