Fix nil interface value when logged (#38)

echocat · Jan 9, 2025 · 4d03d08 · 4d03d08
1 parent 4a54146
commit 4d03d08
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,4 +1,13 @@
-on: [ push, pull_request ]
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    types:
+      - opened
+      - reopened
+      - synchronize
+      - ready_for_review
 name: Continuous Integration
 jobs:
   lint:
@@ -11,7 +20,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.21.1
+          go-version: 1.23.4
 
       - name: Checkout code
         uses: actions/checkout@v4
@@ -44,7 +53,7 @@ jobs:
     name: Test
     strategy:
       matrix:
-        go-version: [ 1.17.0, 1.21.0, 1.22.0 ]
+        go-version: [ 1.18.0, 1.22.0, 1.23.0 ]
         os: [ ubuntu-latest, macos-latest, windows-latest ]
     runs-on: ${{ matrix.os }}
     steps:
@@ -107,7 +116,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.21.1
+          go-version: 1.23.4
 
       - name: Cache
         uses: actions/cache@v4

diff --git a/native/formatter/text_value_simple.go b/native/formatter/text_value_simple.go
@@ -3,6 +3,7 @@ package formatter
 import (
 	"encoding/json"
 	"fmt"
+	"reflect"
 
 	log "github.com/echocat/slf4g"
 	"github.com/echocat/slf4g/fields"
@@ -28,8 +29,16 @@ func NewSimpleTextValue(customizer ...func(*SimpleTextValue)) *SimpleTextValue {
 
 // FormatTextValue implements TextValue.FormatTextValue().
 func (instance *SimpleTextValue) FormatTextValue(v interface{}, _ log.Provider) ([]byte, error) {
-	if vl, ok := v.(fields.Lazy); ok {
+	vv := reflect.ValueOf(v)
+	if vv.Kind() == reflect.Pointer && vv.IsNil() {
+		v = ""
+	} else if vl, ok := v.(fields.Lazy); ok {
 		v = vl.Get()
+
+		vv = reflect.ValueOf(v)
+		if vv.Kind() == reflect.Pointer && vv.IsNil() {
+			v = ""
+		}
 	}
 
 	switch vs := v.(type) {